diff options
| author | Dan Williams <dan.j.williams@intel.com> | 2019-07-18 14:58:43 -0800 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2019-07-18 16:08:07 -0800 |
| commit | 9a845030427c7a2879a7d635cc7c0e5f79ec962d (patch) | |
| tree | 065459104d601679ea9cd203c8360d0826c10261 /mm | |
| parent | a3619190d62ed9d66416891be2416f6bea2b3ca4 (diff) | |
| download | linux-stable-9a845030427c7a2879a7d635cc7c0e5f79ec962d.tar.gz linux-stable-9a845030427c7a2879a7d635cc7c0e5f79ec962d.tar.bz2 linux-stable-9a845030427c7a2879a7d635cc7c0e5f79ec962d.tar.xz linux-stable-9a845030427c7a2879a7d635cc7c0e5f79ec962d.zip | |
mm/sparsemem: cleanup 'section number' data types
David points out that there is a mixture of 'int' and 'unsigned long'
usage for section number data types. Update the memory hotplug path to
use 'unsigned long' consistently for section numbers.
[akpm@linux-foundation.org: fix printk format]
Link: http://lkml.kernel.org/r/156107543656.1329419.11505835211949439815.stgit@dwillia2-desk3.amr.corp.intel.com
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Reported-by: David Hildenbrand <david@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Oscar Salvador <osalvador@suse.de>
Cc: Jason Gunthorpe <jgg@mellanox.com>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm')
| -rw-r--r-- | mm/memory_hotplug.c | 10 | ||||
| -rw-r--r-- | mm/sparse.c | 8 |
2 files changed, 9 insertions, 9 deletions
diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index aafb71594ee3..2a9bbddb0e55 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c | |||
| @@ -288,8 +288,8 @@ static int check_pfn_span(unsigned long pfn, unsigned long nr_pages, | |||
| 288 | int __ref __add_pages(int nid, unsigned long pfn, unsigned long nr_pages, | 288 | int __ref __add_pages(int nid, unsigned long pfn, unsigned long nr_pages, |
| 289 | struct mhp_restrictions *restrictions) | 289 | struct mhp_restrictions *restrictions) |
| 290 | { | 290 | { |
| 291 | unsigned long i; | 291 | int err; |
| 292 | int start_sec, end_sec, err; | 292 | unsigned long nr, start_sec, end_sec; |
| 293 | struct vmem_altmap *altmap = restrictions->altmap; | 293 | struct vmem_altmap *altmap = restrictions->altmap; |
| 294 | 294 | ||
| 295 | if (altmap) { | 295 | if (altmap) { |
| @@ -310,7 +310,7 @@ int __ref __add_pages(int nid, unsigned long pfn, unsigned long nr_pages, | |||
| 310 | 310 | ||
| 311 | start_sec = pfn_to_section_nr(pfn); | 311 | start_sec = pfn_to_section_nr(pfn); |
| 312 | end_sec = pfn_to_section_nr(pfn + nr_pages - 1); | 312 | end_sec = pfn_to_section_nr(pfn + nr_pages - 1); |
| 313 | for (i = start_sec; i <= end_sec; i++) { | 313 | for (nr = start_sec; nr <= end_sec; nr++) { |
| 314 | unsigned long pfns; | 314 | unsigned long pfns; |
| 315 | 315 | ||
| 316 | pfns = min(nr_pages, PAGES_PER_SECTION | 316 | pfns = min(nr_pages, PAGES_PER_SECTION |
| @@ -541,7 +541,7 @@ void __remove_pages(struct zone *zone, unsigned long pfn, | |||
| 541 | unsigned long nr_pages, struct vmem_altmap *altmap) | 541 | unsigned long nr_pages, struct vmem_altmap *altmap) |
| 542 | { | 542 | { |
| 543 | unsigned long map_offset = 0; | 543 | unsigned long map_offset = 0; |
| 544 | int i, start_sec, end_sec; | 544 | unsigned long nr, start_sec, end_sec; |
| 545 | 545 | ||
| 546 | map_offset = vmem_altmap_offset(altmap); | 546 | map_offset = vmem_altmap_offset(altmap); |
| 547 | 547 | ||
| @@ -552,7 +552,7 @@ void __remove_pages(struct zone *zone, unsigned long pfn, | |||
| 552 | 552 | ||
| 553 | start_sec = pfn_to_section_nr(pfn); | 553 | start_sec = pfn_to_section_nr(pfn); |
| 554 | end_sec = pfn_to_section_nr(pfn + nr_pages - 1); | 554 | end_sec = pfn_to_section_nr(pfn + nr_pages - 1); |
| 555 | for (i = start_sec; i <= end_sec; i++) { | 555 | for (nr = start_sec; nr <= end_sec; nr++) { |
| 556 | unsigned long pfns; | 556 | unsigned long pfns; |
| 557 | 557 | ||
| 558 | cond_resched(); | 558 | cond_resched(); |
diff --git a/mm/sparse.c b/mm/sparse.c index a205a2ac66a4..72f010d9bff5 100644 --- a/mm/sparse.c +++ b/mm/sparse.c | |||
| @@ -229,21 +229,21 @@ void subsection_mask_set(unsigned long *map, unsigned long pfn, | |||
| 229 | void __init subsection_map_init(unsigned long pfn, unsigned long nr_pages) | 229 | void __init subsection_map_init(unsigned long pfn, unsigned long nr_pages) |
| 230 | { | 230 | { |
| 231 | int end_sec = pfn_to_section_nr(pfn + nr_pages - 1); | 231 | int end_sec = pfn_to_section_nr(pfn + nr_pages - 1); |
| 232 | int i, start_sec = pfn_to_section_nr(pfn); | 232 | unsigned long nr, start_sec = pfn_to_section_nr(pfn); |
| 233 | 233 | ||
| 234 | if (!nr_pages) | 234 | if (!nr_pages) |
| 235 | return; | 235 | return; |
| 236 | 236 | ||
| 237 | for (i = start_sec; i <= end_sec; i++) { | 237 | for (nr = start_sec; nr <= end_sec; nr++) { |
| 238 | struct mem_section *ms; | 238 | struct mem_section *ms; |
| 239 | unsigned long pfns; | 239 | unsigned long pfns; |
| 240 | 240 | ||
| 241 | pfns = min(nr_pages, PAGES_PER_SECTION | 241 | pfns = min(nr_pages, PAGES_PER_SECTION |
| 242 | - (pfn & ~PAGE_SECTION_MASK)); | 242 | - (pfn & ~PAGE_SECTION_MASK)); |
| 243 | ms = __nr_to_section(i); | 243 | ms = __nr_to_section(nr); |
| 244 | subsection_mask_set(ms->usage->subsection_map, pfn, pfns); | 244 | subsection_mask_set(ms->usage->subsection_map, pfn, pfns); |
| 245 | 245 | ||
| 246 | pr_debug("%s: sec: %d pfns: %ld set(%d, %d)\n", __func__, i, | 246 | pr_debug("%s: sec: %lu pfns: %lu set(%d, %d)\n", __func__, nr, |
| 247 | pfns, subsection_map_index(pfn), | 247 | pfns, subsection_map_index(pfn), |
| 248 | subsection_map_index(pfn + pfns - 1)); | 248 | subsection_map_index(pfn + pfns - 1)); |
| 249 | 249 | ||
