libbindle: refactoring bindle_strsadd()

1 files changed, 9 insertions, 4 deletions

diff --git a/lib/libbindle/lstrings.c b/lib/libbindle/lstrings.c
index 80f34e8..2d44c58 100644
--- a/lib/libbindle/lstrings.c
+++ b/lib/libbindle/lstrings.c
@@ -78,6 +78,7 @@ bindle_strsadd(
 {
    size_t     count;
    char **    strs;
+   char *     dup;
 
    BindleDebugTrace();
 
@@ -86,14 +87,18 @@ bindle_strsadd(
 
    count = bindle_strscount(*strsp);
 
+   // copy string
+   if ((dup = bindle_strdup(str)) == NULL)
+      return(ENOMEM);
+
    // increase size of array
    if ((strs = realloc(*strsp, (sizeof(char *)*(count+2)))) == NULL)
+   {
+      free(dup);
       return(ENOMEM);
+   };
    *strsp        = strs;
-
-   // copy string
-   if ((strs[count] = bindle_strdup(str)) == NULL)
-      return(ENOMEM);
+   strs[count]   = dup;
 
    // terminate array
    count++;